Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy-bundle arguments fail #6

Closed
azamat-sharapov opened this issue Aug 3, 2020 · 4 comments
Closed

deploy-bundle arguments fail #6

azamat-sharapov opened this issue Aug 3, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@azamat-sharapov
Copy link

Orb Version

1.0.1

Describe the bug

When you pass arguments to deploy-bundle command, it passes them both for aws deploy create-deployment and aws deploy get-deployment, resulting deployment failure, like: Unknown options: --file-exists-behavior=OVERWRITE

To Reproduce

    steps:
      - aws-cli/setup
      ...
      - aws-code-deploy/deploy-bundle:
          ...
          arguments: "--file-exists-behavior OVERWRITE"

Expected behavior

We probably need 2 params for this. One for create-deployment subcommand, another for get-deployment.

@azamat-sharapov azamat-sharapov added the bug Something isn't working label Aug 3, 2020
@btv
Copy link

btv commented Oct 14, 2020

I am coming across this problem as well and would love to have either a work around or a fix.

@btv
Copy link

btv commented Oct 14, 2020

I think this is a general problem with "arguments", I tried to use the --ignore-application-stop-failures argument, and I get the same error. Looking at the error,

while [[ $STATUS == "Created" || $STATUS == "InProgress" || $STATUS == "Pending" || $STATUS == "Queued" || $STATUS == "Ready" ]]; do
  echo "Status: $STATUS..."
  STATUS=$(aws deploy get-deployment \
            --deployment-id $ID \
            --output text \
            --query '[deploymentInfo.status]' --ignore-application-stop-failures)
  sleep 5
done

it make me wonder if the get-deployment commnd, needs the arguments field inputs at all?

@azamat-sharapov
Copy link
Author

As a workaround, I copied whole deploy-bundle command from orb source and edited it manually.

@EricRibeiro
Copy link

The issue was resolved in the PR #11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants