Add deploy-bundle-arguments to deploy-bundle command

[denisemauldin]

Fixes #6 by adding deploy-bundle-arguments to the deploy-bundle command.

[denisemauldin]

@gmemstr Does this work as alternate to #7 to add a separate configuration for arguments for deploy-bundle?

[denisemauldin]

Also tagging @KyleTryon for visibility. I'm hoping to get this merged soon so that I don't have to go the route of the contributor to #7 and make my own copy of this orb.

[KyleTryon]

Triggering tests:
edit: rebuilding alpha version and adding an empty commit to re-trigger.

[denisemauldin]

@KyleTryon Is that something I need to do?

[denisemauldin]

@KyleTryon I pushed a small change to see if that would help, but it seems that I can't trigger the tests?

[KyleTryon]

Hi @denisemauldin,
We set these tests not to run on forked PRs because the pipeline relies on secrets that you will not have access to, so the pipeline would fail in either case. What I can do is pull your changes into a local branch and push it to trigger tests.

Error:

Error: Error calling command: 'deploy-bundle'
Arguments referenced without declared parameters: arguments
Error calling job: 'deploy'
Error calling command: 'deploy-bundle'
Arguments referenced without declared parameters: arguments

Locally you can run circleci orb pack src > orb.yml to generate a local packed yaml version of the orb.
Then, run circleci orb validate orb.yml for basic validation errors. We can trigger the full pipeline for the integration tests.

[denisemauldin]

@KyleTryon Is the solution to this to add arguments back to deploy-bundle or to remove arguments from the deploy-bundle reference?

[KyleTryon]

@KyleTryon Is the solution to this to add arguments back to deploy-bundle or to remove arguments from the deploy-bundle reference?

It looks like you are trying to replace the original parameter "arguments". The parameter has been renamed, but it must also be renamed where it has been utilized as well:

aws-code-deploy-orb/src/commands/deploy-bundle.yml

Line 55 in fec6fa0

--query '[deploymentInfo.status]'<<# parameters.arguments >> << parameters.arguments >><</parameters.arguments >>)

<< parameters.arguments >> is still being referenced, but no longer exists as a parameter.

[denisemauldin]

@KyleTryon Replaced arguments with get-deployment-group-arguments because deploy-bundle is running get-deployment

[KyleTryon]

@denisemauldin could I bother you to update these linting errors: https://app.circleci.com/pipelines/github/CircleCI-Public/aws-code-deploy-orb/34/workflows/4e3c3861-4513-4697-8647-7b26f80c9270/jobs/80

I don't want to get out of sync with your fork.

Im confused it is complaining about this given, I don't think you modified this portion. Sorry about that, I wonder if a previous PR was not held to the same standard. I'll be sure once we get this PR packed up to give the whole orb a review and get rid of all of the warnings.

If you wouldnt mind just adding a blank line to the end of the deploy file to appease the hard error. The descriptions are written a little funny but it should still work (especially if you did not change them as it appears).

[denisemauldin]

@KyleTryon Fixed the error and some of the warnings.

[KyleTryon]

This issue looks to be on our end. Please allow me some time to look into this.

[denisemauldin]

@KyleTryon Thanks! I appreciate your help on getting this released. :)

[KyleTryon]

@denisemauldin Could I ask you to update the config file? There are currently some hard-coded AWs instance IDs that no longer exist, giving us our issue. I have created a new environment variable $AWS_CD_EC2_ID to replace this so that we can more easily rotate it out.

Upon revising this orb we may instead implement Terraform for our testing. Sorry for the inconvenience. If this does not work, I will attempt to create a branch and see if I can send a PR to your fork perhaps (to keep your credit for this work).

https://github.com/denisemauldin/aws-code-deploy-orb/blob/ad4a9ee7e63fe028572b5f48f34dcbe7c9c22e3e/.circleci/config.yml#L36

https://github.com/denisemauldin/aws-code-deploy-orb/blob/ad4a9ee7e63fe028572b5f48f34dcbe7c9c22e3e/.circleci/config.yml#L49

to this: aws ec2 stop-instances --instance-ids "$AWS_CD_EC2_ID"

[denisemauldin]

@KyleTryon Updated the config

[denisemauldin]

@KyleTryon Let me know if there's anything I can do to assist. I'm fine with you fixing this on a separate branch/PR and closing this one if it's out of date. :)

[KyleTryon]

@KyleTryon Let me know if there's anything I can do to assist. I'm fine with you fixing this on a separate branch/PR and closing this one if it's out of date. :)

Thank you, sorry for the delay, we will get to this asap.

[denisemauldin]

@KyleTryon Thanks for your help as this is currently blocking our deploy process

[denisemauldin]

@KyleTryon Hey Kyle! Do you have any updates for when this orb might be fixed? Thanks!

[KyleTryon]

@KyleTryon Hey Kyle! Do you have any updates for when this orb might be fixed? Thanks!

Sorry again for the delays, I will take some time today on this which I will hope is enough to at least get the change out, but I will attempt to make sure this will go no longer than this week. Thank you for your patience.

[KyleTryon]

Merged via #11. 2.0.0 released. Thank you @denisemauldin .

[denisemauldin]

Thank you @KyleTryon !