Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: v8.1.2 #196

Merged
merged 3 commits into from
May 3, 2022
Merged

fix: v8.1.2 #196

merged 3 commits into from
May 3, 2022

Conversation

brivu
Copy link
Contributor

@brivu brivu commented May 3, 2022

@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/aws-ecr?version=dev:c28c3f650189ae6ac48fe396bf5923c705483b5b

@brivu brivu merged commit 2054340 into master May 3, 2022
@brivu brivu deleted the v8.1.2 branch May 3, 2022 18:13
@zbroniszewski
Copy link

@brivu @KyleTryon I'm not able to find where these changes fix role-arn not interpolating value from project environment variable #194

In fact, I am still experiencing the same issue:
Parameter validation failed: Invalid length for parameter RoleArn, value: 17, valid min length: 20

@zbroniszewski
Copy link

@brivu @KyleTryon I'm not able to find where these changes fix role-arn not interpolating value from project environment variable #194

In fact, I am still experiencing the same issue: Parameter validation failed: Invalid length for parameter RoleArn, value: 17, valid min length: 20

Apologies, I do see the fix on the aws-cli-orb here: CircleCI-Public/aws-cli-orb#108

Though it doesn't seem like aws-ecr-orb 8.1.2 is using aws-cli-orb 3.1.1 (It defines aws-cli@3.1, and I'm not sure if that automatically includes the latest patch?)

@lucapino-kobalt
Copy link

same issue here, it looks like this version was built the day before aws-cli@3.1.1 came out, so those changes for the env var based role-arn do not seem to have made it in.

I suppose a new release should just pick the latest patch, thanks to the semantic versioning. @KyleTryon @brivu can we have a new patch release of this orb, to pick up the other orb changes? do we need to create another issue for #194 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants