Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added push-image command #237

Merged
merged 6 commits into from
Nov 8, 2022
Merged

feat: added push-image command #237

merged 6 commits into from
Nov 8, 2022

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Nov 2, 2022

This PR adds the push-image command to the aws ecr orb, enabling customers to push images that have been built outside of the docker build command

@brivu brivu requested a review from Jaryt November 2, 2022 18:34
@brivu brivu self-assigned this Nov 2, 2022
@brivu brivu requested a review from KyleTryon as a code owner November 2, 2022 18:34
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/aws-ecr?version=dev:7e527ecb85d7d3f49e7d07d4cd19682cb63fb72b

@brivu brivu linked an issue Nov 2, 2022 that may be closed by this pull request
Readd push-image command #199
Closed
Jaryt
Jaryt suggested changes Nov 2, 2022
View reviewed changes
src/scripts/push-image.sh Outdated Show resolved Hide resolved
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/aws-ecr?version=dev:9218f572ceffc1464fdc790e18d306384c3dcb84

@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/aws-ecr?version=dev:7dd33c9fcc6387a04e503bbd03a311fa9fe6d910

@Quidge Quidge mentioned this pull request Nov 4, 2022
Closed
3 tasks
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/aws-ecr?version=dev:26bfe0e11f7e2a18b090b7c965e5d682e0f7db44

Jaryt
Jaryt approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@Jaryt Jaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better! Good job 😄

@brivu brivu merged commit 1071ee6 into master Nov 8, 2022
@brivu brivu deleted the implement-push-image branch November 8, 2022 20:21
@odie5533 odie5533 mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaryt Jaryt Jaryt approved these changes

@felicianotech felicianotech Awaiting requested review from felicianotech

@KyleTryon KyleTryon Awaiting requested review from KyleTryon

Assignees

@brivu brivu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readd push-image command
3 participants
@brivu @orb-publisher @Jaryt