Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add build-path parameter #251

Merged
merged 3 commits into from
Dec 12, 2022
Merged

feat: add build-path parameter #251

merged 3 commits into from
Dec 12, 2022

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Dec 12, 2022

This PR adds the build-path parameter to the docker-build-and-push-image command and job along with the build-image command.

This enables users to specify the path of the build directory in the case that it differs from the path to the Dockerfile.

@brivu brivu requested a review from a team as a code owner December 12, 2022 17:38
@brivu brivu self-assigned this Dec 12, 2022
@brivu brivu linked an issue Dec 12, 2022 that may be closed by this pull request
Split path to Dockerfile and path to build context #220
Closed
@brivu brivu mentioned this pull request Dec 12, 2022
Closed
3 tasks
EricRibeiro
EricRibeiro approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@EricRibeiro EricRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brivu brivu merged commit 8b56848 into master Dec 12, 2022
@brivu brivu deleted the add-build-path branch December 12, 2022 17:59
@SasakiYuta-mf SasakiYuta-mf mentioned this pull request Dec 21, 2022
Closed
@Jonathan-Landeed Jonathan-Landeed mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricRibeiro EricRibeiro EricRibeiro approved these changes

@KyleTryon KyleTryon KyleTryon approved these changes

Assignees

@brivu brivu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split path to Dockerfile and path to build context
3 participants
@brivu @EricRibeiro @KyleTryon