fix: extra-build-args expansion #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleTryon
approved these changes
Dec 14, 2022
|
@brivu can we have a bugfix release for this asap. I have been waiting to use 8.2.0 for a while now by using a random development build which I think is somewhat out of date soon. |
|
@morloderex, Brian released the fix on v8.2.1. |
brivu
added a commit
that referenced
this pull request
Apr 17, 2023
* fix: use runtime expansion for extra build args * fix: fix variable name
brivu
added a commit
that referenced
this pull request
Apr 19, 2023
* feat: add builder-context-name parameter * ci: add multi-platform to test dlc * fix: remove builder-name parameter * fix: remove quotes from extra-build-args * fix: remove quotes from extra-build-args * fix: remove quotes from extra-build-args * fix: remove quotes from extra-build-args * fix: remove set --@ * ci: add multiple build args * ci: add multiple build args * ci: add multiple build args * test: remove variable eval * test: remove variable eval * fix: add docker builder name to fix dlc * fix: extra-build-args expansion (#254) * fix: use runtime expansion for extra build args * fix: fix variable name * fix: remove duplicate parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
PRseparates the expansion of theextra-build-argsfrom the$@array and expands with${ORB_EVAL_EXTRA_BUILD_ARGS:+$ORB_EVAL_EXTRA_BUILD_ARGS}at runtime.