Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: orb tools 12 migration #275

Merged
merged 14 commits into from
Jun 15, 2023
Merged

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Jun 7, 2023

Description

This PR updates the AWS ECR Orb to the new major version of Orb Tools. As it contains breaking changes, several modifications were unnecessary to move from v11 to v12.

Changes

  1. All parameters and commands containing dashes have been converted to the new snake case standard (replace - with _).
  2. The comprehensive list of changes can be found below.

Changes in .circleci/config.yml:

  1. Update the orb-tools version from 11.6 to 12.0.
  2. Move the job requirement list from orb-tools/publish to orb-tools/continue.
  3. Remove the orb-tools/publish job since development versions are no longer necessary.
  4. Add the new orb_name parameter in orb-tools/continue.
  5. Rename the orb-tools/continue job parameters to comply with the new snake case standard.
    • orb_name, pipeline_number and vcs_type.

Changes in .circleci/test-deploy.yml:

  1. Update the orb-tools version from 11.6 to 12.0.
  2. Remove the aws-cli: circleci/aws-cli@dev:<<pipeline.git.revision>> line, and replace it with aws-cli: {}.
  3. Remove the orb-tools/lint, orb-tools/pack, and orb-tools/review jobs. ⚠️
  4. Rename the orb-tools/publish job parameters to comply with the new snake case standard.
    • orb_name, vcs_type, pub_type, enable_pr_comment and github_token.
  5. Change the orb-tools/pack filter to trigger only on tagged releases.

@brivu brivu requested a review from a team as a code owner June 7, 2023 15:37
@brivu brivu force-pushed the refactor/orb-tools-12-migration branch from 4594751 to 0e60d20 Compare June 7, 2023 15:39
README.md Outdated Show resolved Hide resolved
src/executors/default.yml Outdated Show resolved Hide resolved
src/commands/tag_image.yml Outdated Show resolved Hide resolved
brivu and others added 4 commits June 14, 2023 15:26
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
…-Public/aws-ecr-orb into refactor/orb-tools-12-migration
src/scripts/tag_image.sh Outdated Show resolved Hide resolved
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu brivu merged commit db3c9cf into master Jun 15, 2023
2 checks passed
@brivu brivu deleted the refactor/orb-tools-12-migration branch June 15, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants