feat!: add registry login parameter #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brivu
changed the title
brivu
force-pushed
the
feat/image-registry-login
branch
from
d3dd157
to
2117be0
Compare
brivu
force-pushed
the
feat/image-registry-login
branch
from
086c4fc
to
8f0b269
Compare
This was referenced Jul 27, 2023
KyleTryon
approved these changes
Jul 28, 2023
| type: steps | ||
| default: | ||
| - run: >- | ||
| echo "Error - container_registry_login parameter is set to true without |
There was a problem hiding this comment.
We should add a link to the examples in the orb registry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, users need to log into different container registries in order to pull images required to build their docker images in the
build-and-pushcommand.Right now, only
DockerHubis supported. This pull request adds the ability for users to log into other container registries such asHerokuorGitHubwith the use of thecontainer_registry_loginparameter.If the
container_registry_loginparameter is set to true, the user can provide custom login steps to any container registry with theregistry_loginparameter.