Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: rename registry_id and change type #295

Merged
merged 4 commits into from
Aug 8, 2023
Merged

refactor!: rename registry_id and change type #295

merged 4 commits into from
Aug 8, 2023

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Aug 8, 2023

This PR renames the registry_id parameter to account_id, matching the AWS Documentation.

It also changes the type of this parameter from env_var_name to string with the default value of ${AWS_ACCOUNT_ID}

@brivu brivu requested a review from a team as a code owner August 8, 2023 20:28
@brivu brivu merged commit 5407bb2 into master Aug 8, 2023
2 checks passed
@brivu brivu deleted the refactor/registry_id branch August 8, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricRibeiro EricRibeiro EricRibeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brivu @EricRibeiro