Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set profile when calling aws ecr put-lifecycle-policy (#311) #312

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: set profile when calling aws ecr put-lifecycle-policy (#311) #312

merged 1 commit into from
Dec 5, 2023

Conversation

toini
Copy link
Contributor

@toini toini commented Nov 29, 2023

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

Fix for #311

Description

Specify profile name when calling aws ecr put-lifecycle-policy.

@toini toini marked this pull request as ready for review November 29, 2023 14:02
@toini toini requested a review from a team as a code owner November 29, 2023 14:02
@brivu brivu self-assigned this Dec 5, 2023
@brivu brivu linked an issue Dec 5, 2023 that may be closed by this pull request
Profile name not set when calling aws ecr put-lifecycle-policy #311
Closed
brivu
brivu approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you!

@brivu brivu merged commit a9ca2ca into CircleCI-Public:master Dec 5, 2023
2 checks passed
@toini toini deleted the set-profile-name-put-lifecycle-policy branch December 7, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brivu brivu brivu approved these changes

Assignees

@brivu brivu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profile name not set when calling aws ecr put-lifecycle-policy
2 participants
@toini @brivu