refactor: revert to eval #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert back to eval echo instead of circleci env subst * Trigger build * Disable integration tests * Disable integration tests * Use tibber's circle ci publishing context * Fix piped commands * Enable integration tests * Set orb_name * Rename ORB_STR to ORB_EVAL when echo eval used to set value * Fix merge error * Fix ORB_STR_AWS_DOMAIN * Set profile for put-lifecycle-policy
This was
linked to
issues
Jan 18, 2024
EricRibeiro
approved these changes
Jan 18, 2024
|
👋 @brivu any updates on the timeline for next release which will include this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
9.0.0of this orb replacedevalwithcicleci env subst.This had unintended consequences like:
${CIRCLE_SHA1:0:7})This PR reverts back to using
evalfor variable expansion.PLEASE NOTE: We will be reintroducing
circleci env substagain in a later major release but just wanted to make this change to include bug fixes for folks using older versions of the orb.