Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: aws ecr credential helper #327

Merged
merged 4 commits into from
Jan 30, 2024
Merged

feat: aws ecr credential helper #327

merged 4 commits into from
Jan 30, 2024

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Jan 29, 2024

This pull request installs the aws ecr credential helper and uses it to log into ECR.

It replaces the standard login and removes this warning:

WARNING! Your password will be stored unencrypted in /home/circleci/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

@brivu brivu requested a review from a team as a code owner January 29, 2024 20:04
@brivu brivu self-assigned this Jan 29, 2024
@brivu brivu linked an issue Jan 29, 2024 that may be closed by this pull request
AWS ECR Credential Helper #317
Closed
KyleTryon
KyleTryon reviewed Jan 29, 2024
View reviewed changes
src/scripts/ecr_login.sh Outdated Show resolved Hide resolved
@brivu brivu merged commit 55f3694 into master Jan 30, 2024
2 checks passed
@brivu brivu deleted the feat/credential-helper branch January 30, 2024 22:18
@hylaride hylaride mentioned this pull request Mar 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjohnso5 bjohnso5 bjohnso5 left review comments

@KyleTryon KyleTryon KyleTryon approved these changes

Assignees

@brivu brivu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS ECR Credential Helper
3 participants
@brivu @bjohnso5 @KyleTryon