Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[semver:major] ECS Orb 2.0 Update #118

Merged
merged 130 commits into from
Feb 11, 2021
Merged

[semver:major] ECS Orb 2.0 Update #118

merged 130 commits into from
Feb 11, 2021

Conversation

KyleTryon
Copy link
Contributor

@KyleTryon KyleTryon commented Dec 14, 2020

Changes:

  • MODIFIED: source structure and development pipeline to mirror Orb Development Kit for easier testing and updating.
    • Shell and Python Scripts have been migrated to the src/scripts directory
  • UPDATED: AWS CLI Orb to 1.3 - BREAKING CHANGE
  • MODIFIED: launch-type parameter is now an enum, which accepts a blank string as one of the values
  • ADDED: capacity-provider-strategy parameter
    • Description: The capacity provider strategy to use for the task. If a capacity-provider-strategy is specified, the launch-type parameter must be set to an empty string.
  • ADDED: Usage Example for utilizing Fargate Spot
  • ADDED: New Test Job - test-fargatespot
    • Associates the FARGATE and FARGATE SPOT capacity providers with the existing Fargate cluster tests
    • Runs a task with the new custom capacity-provider-strategy parameter, enabling the task to run on Fargate SPOT
  • MODIFIED: Config organization

Copy link
Contributor

@lokst lokst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work splitting up the orb.yml.hbs file into scripts with circleci orb pack! It's much more maintainable now 🎉 I left some comments for your consideration

.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
README.MD Outdated Show resolved Hide resolved
src/scripts/run-task.sh Outdated Show resolved Hide resolved
src/scripts/run-task.sh Show resolved Hide resolved
src/scripts/update-bluegreen-service-via-task-def.sh Outdated Show resolved Hide resolved
src/scripts/update-service-via-task-def.sh Outdated Show resolved Hide resolved
src/scripts/verify-revision-is-deployed.sh Outdated Show resolved Hide resolved
src/scripts/verify-revision-is-deployed.sh Show resolved Hide resolved
@KyleTryon KyleTryon requested a review from lokst February 8, 2021 21:46
@lokst
Copy link
Contributor

lokst commented Feb 9, 2021

@KyleTryon Great work getting to green and thanks for looking into my feedback! Do you think it's feasible to retain running the python unit tests?

@KyleTryon
Copy link
Contributor Author

@KyleTryon Great work getting to green and thanks for looking into my feedback! Do you think it's feasible to retain running the python unit tests?

Tests re-added

Copy link

@gmemstr gmemstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - it's a pretty beefy PR, so I would love a second pair of eyes on it, but going to go ahead and approve it.

Copy link
Contributor

@lokst lokst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and I see that the tests are passing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants