Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added maxsplit=1 to split method to handle base64 values #170

Merged
merged 2 commits into from
Jun 27, 2022
Merged

fix: added maxsplit=1 to split method to handle base64 values #170

merged 2 commits into from
Jun 27, 2022

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Jun 27, 2022 •
edited

This PR applies a fix for the container-env-var-updates parameter containing base64 values. The use of maxsplit=1 in the python split method prevents trimming the = character in base64 values.

@brivu brivu requested a review from Jaryt June 27, 2022 21:55
@brivu brivu linked an issue Jun 27, 2022 that may be closed by this pull request
container-env-var-updates trims '=' characters from values #109
Closed
Jaryt
Jaryt approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@Jaryt Jaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brivu brivu changed the title fix: added maxsplit=1 to python script for base64 values fix: added maxsplit=1 to split method to handle base64 values Jun 27, 2022
@brivu brivu merged commit f940498 into master Jun 27, 2022
@brivu brivu deleted the fix-env-var-updates-base64 branch June 27, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaryt Jaryt Jaryt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

container-env-var-updates trims '=' characters from values
2 participants
@brivu @Jaryt