Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ephemeral storage retention #177

Merged
merged 3 commits into from
Aug 11, 2022
Merged

fix: ephemeral storage retention #177

merged 3 commits into from
Aug 11, 2022

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Aug 11, 2022

When updating a task definition that includes ephemeralStorage and then running update-service command, the ephemeralStorage information gets dropped.

This PR addresses the issue by extracting the ephemeralStorage value using jq and exporting to the environment variable CCI_ORB_AWS_ECS_EPHEMERAL_STORAGE. The variable is then available for use in the update-service command.

@brivu brivu self-assigned this Aug 11, 2022
@brivu brivu linked an issue Aug 11, 2022 that may be closed by this pull request
@Jaryt Jaryt changed the title ifx: ephemeral storage retention fix: ephemeral storage retention Aug 11, 2022
Copy link
Contributor

@Jaryt Jaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brivu brivu merged commit 58e419f into master Aug 11, 2022
@brivu brivu deleted the ephemeralstorage-retention branch August 11, 2022 20:58
@91vikash
Copy link

@brivu Where do I have to set this value ${EPHEMERAL_STORAGE}? I have a pipeline which first creates a task-def using terraform and the circleci-orb ECS deploys that. But I am still seeing ephemeralStorage value is getting dropped.

I am using provider 4.23.0 and circleci or aws-ecs@3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update-service command doesn't carry the ephemeralStorage information
3 participants