Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added profile-name parameter #179

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Aug 11, 2022

This PR passes the profile-name from the update-service-command through to the update-task-definition command. Without passing it through, any time a profile other than the default is used, the update-task-definition command fails.

@brivu brivu merged commit ea4e43d into master Aug 12, 2022
@brivu brivu deleted the fix-update-service-profile branch August 12, 2022 00:40
Copy link
Contributor

@Jaryt Jaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

commands/update-service does not pass the profile-name parameter to the update-task-definition step
3 participants