Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: implement env subst #200

Merged
merged 16 commits into from
Jun 6, 2023
Merged

refactor!: implement env subst #200

merged 16 commits into from
Jun 6, 2023

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Jun 1, 2023

No description provided.

@brivu brivu requested a review from a team as a code owner June 1, 2023 14:30
EricRibeiro
EricRibeiro suggested changes Jun 2, 2023
View reviewed changes
src/scripts/deploy_ecs_scheduled_task.sh Outdated Show resolved Hide resolved
src/scripts/deploy_ecs_scheduled_task.sh Outdated Show resolved Hide resolved
src/scripts/get_prev_task.sh Outdated Show resolved Hide resolved
src/scripts/get_prev_task.sh Outdated Show resolved Hide resolved
src/scripts/get_prev_task.sh Outdated Show resolved Hide resolved
src/scripts/run_task.sh Outdated Show resolved Hide resolved
src/scripts/run_task.sh Outdated Show resolved Hide resolved
src/scripts/update_bluegreen_service_via_task_def.sh Outdated Show resolved Hide resolved
src/scripts/update_service_via_task_def.sh Outdated Show resolved Hide resolved
src/scripts/verify_revision_is_deployed.sh Outdated Show resolved Hide resolved
EricRibeiro
EricRibeiro reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@EricRibeiro EricRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to try and remove the global shellcheck exclusions to see if something comes up.

brivu and others added 13 commits June 2, 2023 16:01
@brivu @EricRibeiro
chore: update src/scripts/deploy_ecs_scheduled_task.sh
2e179c2 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu @EricRibeiro
chore: update src/scripts/deploy_ecs_scheduled_task.sh
9b8b8d5 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu @EricRibeiro
chore: update src/scripts/get_prev_task.sh
b452bfd 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu @EricRibeiro
chore: update src/scripts/get_prev_task.sh
3243b8e 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu @EricRibeiro
chore: update src/scripts/get_prev_task.sh
02d3f86 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu @EricRibeiro
chore: update src/scripts/run_task.sh
8c2bbde 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu @EricRibeiro
chore: update src/scripts/run_task.sh
6f8ba89 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu @EricRibeiro
chore: update src/scripts/update_bluegreen_service_via_task_def.sh
2f6fba9 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu @EricRibeiro
chore: update src/scripts/update_service_via_task_def.sh
92e2328 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu @EricRibeiro
chore: update src/scripts/verify_revision_is_deployed.sh
6d3bed1 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu
refactor: remove global shellcheck exclusions
b9136b5
@brivu
fix: address shell check errors
95b3ff0
@brivu
chore: update provider version
6f92617
@brivu brivu merged commit 9a7f618 into master Jun 6, 2023
2 checks passed
@brivu brivu deleted the refactor/implement-env-subst branch June 6, 2023 23:03
@diogonicoleti diogonicoleti mentioned this pull request Jul 5, 2023
Closed
@brivu brivu self-assigned this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricRibeiro EricRibeiro EricRibeiro approved these changes

Assignees

@brivu brivu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brivu @EricRibeiro