Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sbt #88

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Add sbt #88

merged 2 commits into from
Sep 14, 2021

Conversation

keirlawson
Copy link
Contributor

Closes #87

@keirlawson keirlawson requested review from felicianotech and a team as code owners July 21, 2021 15:44
@felicianotech
Copy link
Contributor

Hi, thank you for this PR.

It looks good but as per the readme, we don't update the Dockerfiles for existing images, just the Dockerfile.template. Would you be able to update this PR with that change so we can get this merged in?

felicianotech
felicianotech approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@felicianotech felicianotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged. Thank you for the contribution. I know a few people were looking forward to this change.

@felicianotech felicianotech merged commit 30a7706 into CircleCI-Public:master Sep 14, 2021
@felicianotech
Copy link
Contributor

This change will roll out only to future image releases. Anything that is already published won't get it. As this is a change needed for the migration from circleci/openjdk to cimg/openjdk, we will consider re-spinning an existing image upon request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicianotech felicianotech felicianotech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SBT
2 participants
@keirlawson @felicianotech