Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced version support for alias and params. #17

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

FelicianoTech
Copy link
Contributor

This PR completely reworks how cimg-shared handles version numbers on the command-line. The logic in this repository is handled by two scripts, release.sh and gen-dockerfiles.sh. Both have been updated to improve support, fix a bug, and lay the ground work for future features.

What in this PR:

  1. gen-dockerfiles.sh now supports being passed multiple versions at once.
  2. release.sh always supported multiple versions but it didn't work before num. 1 above. Now it has been adjusted to work in conjunction with gen-dockerfiles.sh.
  3. release.sh now supports being passed an additional parameter the way gen-dockerfiles.sh has. Both now refer to this as param1 rather than sha. The more broad naming allows it to be used for more situations such as the download URL for the cimg-openjdk builds.
  4. These scripts now have a concept of version groups. They can be passed just a version, or a version with a combination of an alias (for Docker tag purposes) or a generic parameter which can be anything that the Dockerfile templates might need. Versions can now also be prefixed with a v.
  5. A bug fix. A recent PR in this repo enabled support for shared variants for images. This created a bug for images that doesn't currently have a variant (i.e. cimg-node) in which is was trying to process variants that weren't there. This PR fixes that.

What's Not in this PR:

  1. Full alias support. The ground work for supporting aliases is in this PR, but the work to actually pass that info to Docker and eventually Docker Hub is not yet done. That will follow once this PR is merged.

Closes #15, closes #14, and closes #1.

Copy link

@lokst lokst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FelicianoTech FelicianoTech merged commit 9a4d788 into master Apr 21, 2020
@FelicianoTech FelicianoTech deleted the advanced-version-support branch April 21, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release versioning support. Support multiple releases at once Verify passed in SHAs
2 participants