Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew has some issue updating to the latest release version #303

Closed
chenrui333 opened this issue May 16, 2019 · 3 comments
Closed

Homebrew has some issue updating to the latest release version #303

chenrui333 opened this issue May 16, 2019 · 3 comments

Comments

@chenrui333
Copy link

relates to #256
Also relates to Homebrew/homebrew-core#39797

Basically, I am not quite sure how to introduce packr process into the formula testing.

Might need some eyes and help on this.

@zzak
Copy link
Contributor

zzak commented May 16, 2019

Hello @chenrui333!

Thank you for your help on this!! 🙇

I've been meaning to get around to this, sorry for the delay.

I think all we need to do is make sure make pack is run prior to go build command in the formula.

Would you mind giving that a shot and report your findings?

Thanks!

@chenrui333
Copy link
Author

yeah, that seems what I saw in the travis build as well, but not quite sure how the install process would look like for make pack, I will give a try. 😄

@zzak
Copy link
Contributor

zzak commented May 22, 2019

Thanks @chenrui333 for your help here!

We can safely close this issue now thanks to your PR:
Homebrew/homebrew-core#39797

@zzak zzak closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants