Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deploy steps to run #129

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix: replace deploy steps to run #129

merged 1 commit into from
Jun 13, 2022

Conversation

kelvintaywl
Copy link
Contributor

Checklist

Updates deploy steps to use run instead.

Resolves #128

I was able to verify that compiled Orb is valid:

$ circleci orb process src/@orb.yml > orb.yml
$ circleci orb validate orb.yml
Orb at `orb.yml` is valid.

I checked that the update-description command is also tested under the publish-docker-update-description test case.

example: https://app.circleci.com/pipelines/github/CircleCI-Public/docker-orb/796/workflows/92fbd710-d32d-492a-b4e0-79362afef857/jobs/13674

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

Description

@kelvintaywl kelvintaywl requested a review from a team as a code owner May 30, 2022 05:04
@EricRibeiro
Copy link
Contributor

The PR is looking good but the review step is failing because the push.sh file was never imported into the command. I'll push the fix and after squashing it, this PR should be good to be merged.

@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:22775be6edac1f4633b4055f5267ba0383d0bf5c

@EricRibeiro EricRibeiro merged commit 1697d7c into CircleCI-Public:master Jun 13, 2022
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:1697d7c4e1d3b4f0a57e1734e61d9e38c3dc386f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated deploy key is in use
3 participants