Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import the push.sh script in the push command #131

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

EricRibeiro
Copy link
Contributor

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

New PRs are failing the review step because the push command has bash in it. Even though the script was extracted in #120, the code was never replaced with it.

Description

Replace the bash code with an import containing the script path.

@EricRibeiro EricRibeiro requested a review from a team as a code owner June 13, 2022 16:37
@EricRibeiro EricRibeiro merged commit e7143bf into master Jun 13, 2022
@EricRibeiro EricRibeiro deleted the fix_pull_command branch June 13, 2022 16:47
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:e7143bfa5c13d8323a2e83323fc9e3ddbc352d61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants