Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support expanding env vars on the extra_build_args parameter #149

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Support expanding env vars on the extra_build_args parameter #149

merged 3 commits into from
Sep 2, 2022

Conversation

devblackops
Copy link
Contributor

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

Fixes #137

Description

Support expanding env vars on the extra_build_args parameter.

@devblackops devblackops changed the title WIP: Support expanding env vars on the extra_build_args parameter. Support expanding env vars on the extra_build_args parameter. Aug 31, 2022
@devblackops devblackops changed the title Support expanding env vars on the extra_build_args parameter. Support expanding env vars on the extra_build_args parameter Aug 31, 2022
@devblackops devblackops marked this pull request as ready for review August 31, 2022 22:34
@devblackops devblackops requested a review from a team as a code owner August 31, 2022 22:34
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:bf0d47286c28bee276838aaab16a551444eaec23

1 similar comment
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:bf0d47286c28bee276838aaab16a551444eaec23

@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:36d33fefcaccfad0d11861c2e58b5d00999550b0

EricRibeiro
EricRibeiro approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@EricRibeiro EricRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@EricRibeiro EricRibeiro merged commit ce0c7f2 into CircleCI-Public:master Sep 2, 2022
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:ce0c7f2e44bc8b515bc9c95e22af1d7e5f159c13

This was referenced Oct 26, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricRibeiro EricRibeiro EricRibeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support env var substitution for extra_build_args or document limitation
3 participants
@devblackops @orb-publisher @EricRibeiro