Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove scripts from YAML #50

Merged
merged 8 commits into from
Oct 20, 2022
Merged

refactor: remove scripts from YAML #50

merged 8 commits into from
Oct 20, 2022

Conversation

EricRibeiro
Copy link
Contributor

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

This PR will complete the migration to Orb Tools 11 and allow for further updates and improvements.

Description

  • Move all code from initialize to a separate script
  • Move all code from install to a separate script

@EricRibeiro EricRibeiro requested a review from a team as a code owner October 20, 2022 20:25
Jaryt
Jaryt approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@Jaryt Jaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@EricRibeiro EricRibeiro merged commit 66dafec into master Oct 20, 2022
@EricRibeiro EricRibeiro deleted the orb-tools-11-migration branch October 20, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaryt Jaryt Jaryt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EricRibeiro @Jaryt