Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change installation path #63

Merged
merged 2 commits into from
Dec 12, 2022
Merged

fix: change installation path #63

merged 2 commits into from
Dec 12, 2022

Conversation

EricRibeiro
Copy link
Contributor

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

  • Downloading the CLI to the project directory prevents checkout steps from running. They fail with:
Directory (/home/circleci/project) you are trying to checkout to is not empty and not a git repository

Description

This PR changes the installation directory from ~/project to a temporary folder created with mktemp. I opted out of using /usr/local, /usr/bin and /opt because these require root permission for changes, adding a hard dependency on sudo for Alpine.

@EricRibeiro EricRibeiro requested a review from a team as a code owner December 12, 2022 17:29
brivu
brivu approved these changes Dec 12, 2022
View reviewed changes
Copy link

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@EricRibeiro EricRibeiro merged commit e7b7782 into master Dec 12, 2022
@EricRibeiro EricRibeiro deleted the fix/change_install_path branch December 12, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleTryon KyleTryon KyleTryon approved these changes

@brivu brivu brivu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installing gcloud SDK in project root will cause some linting jobs failed
3 participants
@EricRibeiro @KyleTryon @brivu