Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parameter expansion using circleci env subst #71

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

EricRibeiro
Copy link
Contributor

Description

Closes #65 and #66.

Due to the Orb Tools migration, some commands lost the expansion functionality; therefore, the CLI command received literal variables (e.g. CIRCLE_PROJECT_REPONAME).

This PR leverages the recently introduced circleci env subst to expand the parameters and restore the lost functionality.

@EricRibeiro EricRibeiro requested a review from a team as a code owner July 26, 2023 17:45
Copy link

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@EricRibeiro EricRibeiro merged commit 8d81a59 into master Jul 26, 2023
2 checks passed
@EricRibeiro EricRibeiro deleted the fix/parameter_expansion branch July 26, 2023 18:18
@orb-publisher
Copy link

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/gcp-gcr?version=0.15.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker push failing with 0.15.1 patch
3 participants