Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Github CLI "pr merge" command #36

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

Shmarkus
Copy link
Contributor

Implemented gh pr merge with the possibility to define the branch or additional parameters

@Shmarkus Shmarkus requested a review from a team as a code owner December 19, 2022 12:55
@KyleTryon
Copy link
Contributor

Thank you for reminding me the CHANGELOG is still present here. Happy to take the change here, but we no longer user the changelog. I'll be sure to remove it in a change soon. We now use GitHub's Releases API.

https://github.com/CircleCI-Public/github-cli-orb/releases

When we publish this change, we will use this PR to populate the release notes. I'll be sure to update all that documentation. Thank you.

The code looks good. Could I ask how you intend to use this @Shmarkus ? Is there an example of config you could provide on how you plan to execute this?

By default CircleCI will trigger on a Push (including a Tag), we can augment this a bit more with https://github.com/CircleCI-Public/trigger-circleci-pipeline-action

In what scenario would you run this job?

@Shmarkus
Copy link
Contributor Author

I can create a concrete example as well but since I'm not at the computer at the moment, I'll just illustrate my use-case.

At the moment, the Dependabot is configured to check for version updates. It creates a pull request with the new version. (Renovate bot has the same functionality)

When the test pipeline succeeds I want to merge the PR automatically (this is where the pain is at the moment)

@Shmarkus
Copy link
Contributor Author

Added example, removed changelog from changelog

Copy link
Contributor

@KyleTryon KyleTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent and the example is a great/creative use-case, thank you!

@KyleTryon KyleTryon changed the title [semver:minor] Implement Github CLI "pr merge" command feat: Implement Github CLI "pr merge" command Dec 19, 2022
@KyleTryon KyleTryon merged commit 3032307 into CircleCI-Public:main Dec 19, 2022
@Shmarkus Shmarkus deleted the feature/gh-pr-merge branch December 19, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants