Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching the whole .m2 folder also caches settings.xml. #11

Closed
skjolber opened this issue Oct 5, 2020 · 1 comment · Fixed by #12
Closed

Caching the whole .m2 folder also caches settings.xml. #11

skjolber opened this issue Oct 5, 2020 · 1 comment · Fixed by #12
Labels
bug Something isn't working

Comments

@skjolber
Copy link

skjolber commented Oct 5, 2020

1.0.2

Describe the bug
The .m2/repository folder contains the artifacts.
The .m2 folder contains in additon the settings.xml.

So the settings.xml file contains usernames / passords and such, values which can change over time. It should not be cached, but generated each time.

To Reproduce
Use a non-public repo, which requires a settings.xml file.

Expected behavior
Caches artifacts. Does not cache settings.xml. Absolutely does not overwrite an updated settings.xml using old values.

Additional context
This is completly analog to your gradle orb, which caches specific folders within the .gradle folder, not the whole folder itself, which contains the global gradle.properties.

@skjolber skjolber added the bug Something isn't working label Oct 5, 2020
gmemstr pushed a commit that referenced this issue Oct 6, 2020
@gmemstr gmemstr linked a pull request Oct 6, 2020 that will close this issue
gmemstr pushed a commit that referenced this issue Oct 6, 2020
@skjolber
Copy link
Author

skjolber commented Oct 6, 2020

Thanks! That was quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant