-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: yarn install fails when release is tagged in GitHub but not yet published on yarnpkg.com #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thank you very much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eszjay sorry, could I ask you to rebase your PR? We recently updated our CI pipeline and what is happening is the config file for this branch is still being executed, rather than the new config.
Thank you 🙇
…ublished on yarnpkg.com We should check the latest version at the same source we will download from. 1.22.18 was tagged for release on GitHub but 1.22.17 was the latest version on yarnpkg.com. The error was: Latest version of Yarn is 1.22.18 Checking if YARN is already installed... A different version of Yarn is installed (1.22.17); removing it Installing YARN v1.22.18 gzip: stdin: not in gzip format tar: Child returned status 1 tar: Error is not recoverable: exiting now mv: cannot stat ‘yarn-v1.22.18/*’: No such file or directory Exited with code exit status 1 CircleCI received exit code 1
It is rebased, but it looks like the tests did not run. Do they run on branches from forks? |
Totally expected 🙇 thank you. We disable building PRs for security reasons and spam. I can trigger the build on my end though by pulling it into a new branch to trigger the same commit. Starting the tests now but they should be the same so we expect this will go fine. |
Your development orb has been published. It will expire in 30 days. |
Ok It took me a moment but I wanted to make sure we have a solid link between yarn and this CDN and it does appear approved in the link you provided, I just wanted to picture that here: When Iw as searching I did discover this though. It does not need to be addressed in this PR but good to know going forward.
|
We should check the latest version at the same source we will download from.
In this solution, we use the package.json published on https://yarnpkg.com/package/yarn to resolve the latest version.
At the time of the problem, version 1.22.18 was tagged as a release on GitHub but 1.22.17 was the latest version on yarnpkg.com.
The error was: