Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configurable resource classes #170

Conversation

jenny-miggin
Copy link
Contributor

No description provided.

@jenny-miggin jenny-miggin requested a review from a team as a code owner December 15, 2022 16:50
Copy link
Contributor

@KyleTryon KyleTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you 🙏 . Running the tests now.

@KyleTryon
Copy link
Contributor

The issue here @jenny-miggin is not related to your change, it is a bug in an older version of orb-tools. We will update and this PR will need to rebase to pull in the change.

@KyleTryon
Copy link
Contributor

KyleTryon commented Dec 15, 2022

When this is merged shortly, you can run:

git checkout master 
git pull
git checkout add-configurable-resource-classes
git rebase
git push -f

#171

src/jobs/run.yml Show resolved Hide resolved
src/jobs/test.yml Show resolved Hide resolved
src/executors/default.yml Show resolved Hide resolved
@Peter-Darton-i2
Copy link

FYI this will fix issue #160

@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/node?version=dev:ec842b5e009c5f6acec2f154ce484f080aa2b356

@KyleTryon KyleTryon merged commit ceb0383 into CircleCI-Public:master Dec 20, 2022
@Peter-Darton-i2
Copy link

I've just run a build against circleci/node@dev:ceb0383ed3c5b425a7dca94eaed22d26de161717 (which is the most recent publish from the main branch) and it LGTM - my build asked for a medium+ and it got what it asked for.

Is there an ETA for a release?

@KyleTryon
Copy link
Contributor

Hey folks, the release will come soon, we are currently blocked by some temporary security measures in place but will publish ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants