Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update samples #180

Merged
merged 1 commit into from
Feb 27, 2023
Merged

chore: update samples #180

merged 1 commit into from
Feb 27, 2023

Conversation

KyleTryon
Copy link
Contributor

No description provided.

@KyleTryon KyleTryon requested a review from a team as a code owner February 27, 2023 15:06
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/node?version=dev:3644915b9412e7bb802804df882fc34598ea8abf

@KyleTryon
Copy link
Contributor Author

KyleTryon commented Feb 27, 2023

There was a failure to run the tests on MacOS but, that failure can not be related to these changes and will need to be addressed separately. The reported failure refers to installing Node on MacOS. The two mac jobs that did not fail but took a long time compiled Node from source as a last-ditch attempt, and took over 10 minutes. The failing job appeared to have a network-related issue. Waiting for jobs to complete to re-run

Copy link

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KyleTryon KyleTryon merged commit 85ff529 into master Feb 27, 2023
@KyleTryon KyleTryon deleted the update/demo branch February 27, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants