Setting Node version with nvm under machine images [semver:patch]

[felicianotech]

This should be rebased, re-run (and should pass) after #72 is merged.

[dsayling]

any reason to not include this change in #72 ?

[felicianotech]

Just PR etiquette that I like to follow. It's good practice.

For example, Gabe wasn't even sure if we should add this test. This allows us to easily ignore or revert this change without touching #72.

[dsayling]

Just PR etiquette that I like to follow. It's good practice.

For example, Gabe wasn't even sure if we should add this test. This allows us to easily ignore or revert this change without touching #72.

I agree with keeping the changes small, but since this test validates the change in #72, IMHO, I would include it.

[KyleTryon]

I also see the etiquette but feel as though it makes more sense to combine these. Though as the other PR shouldnt have any negative effects, I could take this either way. But as these two changes are related to the same single issue, I'd vote to combine.

[dsayling]

@felicianotech looks like #72 did not resolve #62

[gmemstr]

I'm not 100% on why this is yet but it looks like the nvm version isn't being correctly set in the environment for whatever reason, despite installing fine.

[felicianotech]

@gmemstr @dsayling Can either of you point me to an example of where there is still an issue with the Node.js orb v4.2.0 doesn't work right?

[felicianotech]

I'm still learning how the embedded scripts work. Where does this grep error come from? I don't see where we use it. https://app.circleci.com/pipelines/github/CircleCI-Public/node-orb/687/workflows/4214ce53-c75d-4673-8aeb-a3aec12f1f95/jobs/4459