Prevent invalid warning when var ENV 'ORB_PARAM_ORB_PUB_TOKEN' isn't define #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is ORB_PARAM_ORB_PUB_TOKEN but it is defined via a parameter with a default as CIRCLE_TOKEN. If you set ORB_PARAM_ORB_PUB_TOKEN in a context it will not work with the orb template but if you set CIRCLE_TOKEN it is working properly.
benoittgt
changed the title
KyleTryon
approved these changes
Dec 12, 2022
|
Thank you @benoittgt 🙏 . I see what happened here, |
|
Your development orb has been published. It will expire in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the resolution of this issue can appears weird. But it just happen to me and I had to look at the source code to understand.
Also I think the doc should mention that it is required.
This is ORB_PARAM_ORB_PUB_TOKEN but it is defined via a parameter with a default as CIRCLE_TOKEN.
If you set ORB_PARAM_ORB_PUB_TOKEN in a context it will not work with the orb template but if you set CIRCLE_TOKEN it is working properly.