Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow consumer to set tag for CircleCI images #171

Merged
merged 6 commits into from
Nov 7, 2022
Merged

feat: allow consumer to set tag for CircleCI images #171

merged 6 commits into from
Nov 7, 2022

Conversation

kilahm
Copy link
Contributor

@kilahm kilahm commented Oct 12, 2022

This feature is modeled after https://github.com/CircleCI-Public/shellcheck-orb/blob/master/src/jobs/check.yml#L7 .

I'm attempting to author an Orb within my company's CircleCI Server v3 instance. We have imported the orbs published under the circleci/* namespace. When using the jobs defined in this Orb, I'm getting the following error message at the checkout step:

Using SSH Config Dir '/home/circleci/.ssh'
git version 2.38.0
Cloning git repository
Cloning into '.'...
error: cannot create async thread: Operation not permitted
fatal: fetch-pack: unable to fork off sideband demultiplexer

exit status 128
CircleCI received exit code 128

I'd like this feature as a work-around to the potential underlying issue described here. The workaround is to use an Alpine or Ubuntu 21.04 based image.

@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:faeb34c3272eda2814f0c61a33bb41cf1c23e0b9

@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:77d207d38f3907fb5ffeca96cef61cd4b0c439c0

Copy link
Contributor

@EricRibeiro EricRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kilahm, thank you for your contribution 🙇

I changed the parameter from image-tag to tag to match the naming convention we have in other orbs. Additionally, I changed the default value for the pack and publish jobs. They fail with current as it's not a valid tag for CLI image.

@EricRibeiro EricRibeiro merged commit b21ac73 into CircleCI-Public:master Nov 7, 2022
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:b21ac739a57580616ea10cab6c8bf0cf28fbeadc

@kilahm kilahm deleted the feat_custom_image_tag branch November 7, 2022 16:52
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:b21ac739a57580616ea10cab6c8bf0cf28fbeadc

@orb-publisher
Copy link

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=11.5.0

@kilahm
Copy link
Contributor Author

kilahm commented Nov 9, 2022

Thanks for getting this pushed through!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants