-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow consumer to set tag for CircleCI images #171
feat: allow consumer to set tag for CircleCI images #171
Conversation
Your development orb has been published. It will expire in 30 days. |
Your development orb has been published. It will expire in 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kilahm, thank you for your contribution 🙇
I changed the parameter from image-tag
to tag
to match the naming convention we have in other orbs. Additionally, I changed the default value for the pack
and publish
jobs. They fail with current
as it's not a valid tag for CLI image.
Your development orb has been published. It will expire in 30 days. |
Your development orb has been published. It will expire in 30 days. |
Your orb has been published to the CircleCI Orb Registry. |
Thanks for getting this pushed through! |
This feature is modeled after https://github.com/CircleCI-Public/shellcheck-orb/blob/master/src/jobs/check.yml#L7 .
I'm attempting to author an Orb within my company's CircleCI Server v3 instance. We have imported the orbs published under the
circleci/*
namespace. When using the jobs defined in this Orb, I'm getting the following error message at thecheckout
step:I'd like this feature as a work-around to the potential underlying issue described here. The workaround is to use an Alpine or Ubuntu 21.04 based image.