Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): add pretty output to review job #206

Merged
merged 1 commit into from
May 10, 2023

Conversation

wyardley
Copy link
Contributor

Use pretty output to stdout / stderr, and then also save the junit report

The test results will still be included in the "tests" tab, but this should make the test output a little easier to follow.

note: I'm happy to add back the additional messages and exit code / pointer to look at the tests, but I think this may work as expected without it?

@wyardley wyardley requested a review from a team as a code owner May 10, 2023 16:48
@wyardley
Copy link
Contributor Author

wyardley commented May 10, 2023

basic test / poc locally:
image

Use pretty output to stdout / stderr, and then also save the junit
report

The test results will still be included in the "tests" tab, but this
should make the test output a little easier to follow.
@wyardley
Copy link
Contributor Author

@KyleTryon rebased and fixed the shellcheck warning

@KyleTryon
Copy link
Contributor

I think the github outage is making this difficult to test right now

@orb-publisher
Copy link

Your development orb(s) have been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link(s):
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:845949f5a119ea93ec72ee854faa25fc0b981b96
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:alpha

@KyleTryon
Copy link
Contributor

jk it went through 🎉

@wyardley
Copy link
Contributor Author

wyardley commented May 10, 2023

image

tested it on one of our projects that uses this with the published tag, and that works Ok. (also, your other fixes work great there too)

Copy link
Contributor

@KyleTryon KyleTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, with the output flag there shouldn't be a need to "hack" the exit code. Great addition!

@wyardley
Copy link
Contributor Author

wyardley commented May 10, 2023

image and test results still show up too, despite the filename changing slightly (but not the directory)

@KyleTryon KyleTryon merged commit 1d2ddd8 into CircleCI-Public:master May 10, 2023
2 checks passed
@orb-publisher
Copy link

Your development orb(s) have been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link(s):
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:1d2ddd8fbcda6e84436dc71d49297dc7f2220ee4
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:alpha

@wyardley wyardley deleted the wyardley/report-format branch May 10, 2023 21:07
@KyleTryon
Copy link
Contributor

Thank you @wyardley

@KyleTryon
Copy link
Contributor

Though this was technically a feat, I broke the rules to include it as a patch.
image

@orb-publisher
Copy link

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=12.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants