-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scripts): add pretty output to review job #206
feat(scripts): add pretty output to review job #206
Conversation
2682338
to
8fe159c
Compare
Use pretty output to stdout / stderr, and then also save the junit report The test results will still be included in the "tests" tab, but this should make the test output a little easier to follow.
14087f6
to
845949f
Compare
@KyleTryon rebased and fixed the shellcheck warning |
I think the github outage is making this difficult to test right now |
Your development orb(s) have been published. It will expire in 30 days. |
jk it went through 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, with the output flag there shouldn't be a need to "hack" the exit code. Great addition!
Your development orb(s) have been published. It will expire in 30 days. |
Thank you @wyardley |
Your orb has been published to the CircleCI Orb Registry. |
Use pretty output to stdout / stderr, and then also save the junit report
The test results will still be included in the "tests" tab, but this should make the test output a little easier to follow.
note: I'm happy to add back the additional messages and exit code / pointer to look at the tests, but I think this may work as expected without it?