fix: print correct tag #208
Conversation
src/scripts/publish.sh
Outdated
| @@ -45,7 +45,7 @@ function publishDevOrbs() { | |||
| { | |||
| printf "Your development orb(s) have been published. It will expire in 30 days.\n" | |||
| printf "You can preview what this will look like on the CircleCI Orb Registry at the following link: \n" | |||
| printf "https://circleci.com/developer/orbs/orb/%s?version=dev:%s\n" "${ORB_VAL_ORB_NAME}" "${array[0]}" | |||
| printf "https://circleci.com/developer/orbs/orb/%s?version=%s\n" "${ORB_VAL_ORB_NAME}" "${array[0]}" | |||
There was a problem hiding this comment.
FWIW, I was seeing ${CIRCLE_SHA1} being printed literally vs. being expanded as well, not sure if this will fix that? I wasn't able to reproduce it yet with some local tests.
There was a problem hiding this comment.
Slowly working towards it. Now i just ran into an unhandled authentication error, so we are going to squash few things here lol
|
Your development orb(s) have been published. It will expire in 30 days. |
|
Fixes #204 |
|
Your development orb(s) have been published. It will expire in 30 days. |
1 similar comment
|
Your development orb(s) have been published. It will expire in 30 days. |
|
Your development orb(s) have been published. It will expire in 30 days. |
|
Your development orb(s) have been published. It will expire in 30 days. |
|
Your development orb(s) have been published. It will expire in 30 days. |
|
Your development orb(s) have been published. It will expire in 30 days. |
|
|
Your development orb(s) have been published. It will expire in 30 days. |
Will note that tense is a little inconsistent there. Not sure if it should stick with plural or singular throughout, but maybe pick one or the other? (it vs they etc.) |
| publishOrb "$tag" | ||
| # shellcheck disable=SC2005 | ||
| PROCESSED_TAG=$(circleci env subst "$tag") | ||
| ORB_REG_LINKS+=("$(printf 'https://circleci.com/developer/orbs/orb/%s?version=%s' "$ORB_VAL_ORB_NAME" "$PROCESSED_TAG")") |
|
Your development orb(s) have been published. It will expire in 30 days. |
1 similar comment
|
Your development orb(s) have been published. It will expire in 30 days. |
No description provided.