Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RC010 should ignore components without parameters #210

Merged
merged 1 commit into from
May 19, 2023
Merged

fix: RC010 should ignore components without parameters #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/scripts/review.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,13 @@ setup() {
echo "Component names should be snake_cased. Please rename this file to use snake_case."
exit 1
fi

# Check if the file has parameters, if not skip counting.
HAS_PARAMETERS=$(yq 'has("parameters")' "$i")
if [[ "$HAS_PARAMETERS" == "false" ]]; then
continue
fi

# Check parameter keys on component for snake_case
ORB_COMPONENT_PARAMETERS_COUNT=$(yq '.parameters | keys | .[]' "$i")
for j in $ORB_COMPONENT_PARAMETERS_COUNT; do
Expand Down