Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message when 'saving' a null/0 set of TLD prices #57

Open
bobbravo2 opened this issue Nov 16, 2015 · 3 comments
Open

Show error message when 'saving' a null/0 set of TLD prices #57

bobbravo2 opened this issue Nov 16, 2015 · 3 comments
Labels
Milestone

Comments

@bobbravo2
Copy link
Member

https://mycircletree.com/client-area/ct-admin/supporttickets.php?action=viewticket&id=5765

When there are 0 results to be updated on pressing save, show an error message.

There are 2 error states:

  1. There are 0 checkboxes checked, resulting in the error message "Please use the checkbox to select the TLDs you'd like to import"
  2. There are checkboxes checked, but they are already imported into WHMCS. Resulting error message "There 0 new TLDs to import, to overwrite the pricing already in WHMCS, please use the checkbox"
@bobbravo2 bobbravo2 added the bug label Nov 16, 2015
@bobbravo2 bobbravo2 added this to the 3.1 milestone Nov 16, 2015
@bobbravo2
Copy link
Member Author

@anatoliyrazin there is still case 2.

@anatoliyrazin
Copy link
Contributor

additional notes:

1.1 Save button push works for all records user put numbers whether checkbox selected or not. This behavior does not make any sense with the fix I added previously. I assume we have to fix the bug and save only for those records the check boxed selected

@anatoliyrazin
Copy link
Contributor

2.1 Overwrite check box affects only Preview button and has nothing to do with Save button. Need to discuss and clarify the issue 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants