Support nethermind plugin as data source #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminbollen
approved these changes
Jul 3, 2024
| @@ -4,7 +4,7 @@ namespace CirclesUBI.PathfinderUpdater; | |||
|
|
|||
| public static class Block | |||
| { | |||
| public static async Task<long> FindByTransactionHash(string connectionString, string transactionHash, Queries queries) | |||
| public static async Task<long> FindLatestBlockNumber(string connectionString, Queries queries) | |||
There was a problem hiding this comment.
just curious how the function name and signature changed but nothing else in the function?
There was a problem hiding this comment.
I think i understand how it worked before, and see that now you want to go over every block?
There was a problem hiding this comment.
Good catch. That's basically dead code that was once needed to do partial updates to the pathfinder.
| @@ -70,45 +70,46 @@ from cache_crc_balances_by_safe_and_token | |||
| order by ""blockNumber"" desc, ""transactionIndex"" desc, ""logIndex"" desc; | |||
| "; | |||
|
|
|||
| // TODO: Use the Discounted event from 0.3.4 to get precise demurraged balances | |||
There was a problem hiding this comment.
should we already store "when" (on what day) we've queried these balances?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.