Enable support for mobile-drag-drop polyfill
#781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `$event.preventDefault` on `TreeDropDirective.onDragEnter` for `mobile-drag-drop` polyfill compatibility: https://github.com/timruffles/mobile-drag-drop#polyfill-requires-dragenter-listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommended
DragDropTouchpolyfill for mobile browsers has the limitation of disabling scrolling over draggable elements on mobile devices which also prevents dragging to drop zones beyond the visible scrolling viewport.The
mobile-drag-droppolyfill does not suffer from those limitations and offers additional configurable behavior. However,mobile-drag-dropdoes not detect Angular Tree Component drop zones because at present thedragenterevent listener added byTreeDropDirectivedoes not call$event.preventDefault()as required bymobile-drag-drop.This PR merely calls
$event.preventDefault()inTreeDropDirective.onDragEnterto allow use ofmobile-drag-dropas well asDragDropTouchwith Angular Tree Component.