Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return TreeNode for first and last child #894

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

tobiasengelhardt
Copy link
Contributor

closes #893

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #893

What is the new behavior?

getFirstChild and getLastChild return TreeNode or null again.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@tobiasengelhardt tobiasengelhardt merged commit c0792c3 into master Feb 18, 2021
@tobiasengelhardt tobiasengelhardt deleted the pr/fix-children branch February 18, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getFirstChild and getLastChild return ObservableArray instead of TreeNode
1 participant