feat: noticed integration (Notification Page) #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedant-jain03
added
🌟 feature
work-in-progress
GSoC'22
vedant-jain03
changed the title
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| padding-bottom: 5px; | ||
| } | ||
| .tab_container .active { | ||
| font-weight: bold; |
There was a problem hiding this comment.
Properties should be ordered border-bottom, font-weight
| @@ -95,6 +97,10 @@ def fork(user) | |||
| forked_project.update!( | |||
| view: 1, author_id: user.id, forked_project_id: id, name: name | |||
| ) | |||
| @project = Project.find(id) | |||
| if @project.author != user | |||
There was a problem hiding this comment.
Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tachyons
reviewed
Aug 15, 2022
db/migrate/20220815023618_remove_actvity_notifications_tables.rb
Outdated
Show resolved
Hide resolved
vedant-jain03
force-pushed
the
noticed_integration
branch
from
9aa7153
to
151c6db
Compare
tachyons
reviewed
Aug 16, 2022
tachyons
reviewed
Aug 16, 2022
tachyons
reviewed
Aug 16, 2022
tachyons
reviewed
Aug 16, 2022
db/migrate/20220813051558_populate_noticed_notifications_table.rb
Outdated
Show resolved
Hide resolved
| end | ||
|
|
||
| def mark_all_as_read | ||
| NoticedNotification.where(recipient: current_user, read_at: nil).update_all(read_at: Time.zone.now) |
There was a problem hiding this comment.
Avoid using update_all because it skips validations.
|
Code Climate has analyzed commit d7ebfa0 and detected 7 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Finally 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2321
Describe the changes you have made in this PR -
- Star a Project.
- Fork a Project.
UI
Notification Page
Navbar Quick Notifications
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.