Webpush notification #3273
Open
Webpush notification #3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedant-jain03
added
the
GSoC'22
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| else | ||
| render json: @subscription.errors, status: :unprocessable_entity | ||
| is_subscribed = PushSubscription.find_by(auth: params[:keys][:auth]) | ||
| if !is_subscribed |
There was a problem hiding this comment.
Use a guard clause (return unless !is_subscribed) instead of wrapping the code inside a conditional expression.
| else | ||
| render json: @subscription.errors, status: :unprocessable_entity | ||
| is_subscribed = PushSubscription.find_by(auth: params[:keys][:auth]) | ||
| if !is_subscribed |
There was a problem hiding this comment.
Favor unless over if for negative conditions.
This reverts commit 820698a.
vedant-jain03
force-pushed
the
webpush_notification
branch
from
c47aa42
to
3303926
Compare
|
Code Climate has analyzed commit 6583b0c and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3271
Describe the changes you have made in this PR -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.