feat: added NewAssignmentNotification - to all groupmembers

[VaibhavUpreti]

Fixes #3294

Describe the changes you have made in this PR -

• added notifications to group members on new Assignment creation

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

[coveralls]

Coverage increased (+0.07%) to 82.109% when pulling 0af622b on VaibhavUpreti:NewAssignmentNotification into d27a74b on CircuitVerse:master.

[VaibhavUpreti]

@vedant-jain03 kindly review.

[vedant-jain03]

Thanks @VaibhavUpreti , here are my reviews!
Kindly go through and let me know if you have any doubt!

cc @tachyons

[vedant-jain03]

@VaibhavUpreti could you please add spec testcases for this notifications!

Also test if the assignment got deleted, the associated notification are destroying or not!
That is the edge case, we need to see!

I think has_noticed_notifications do this thing but just in case kindly test this in your end!

[VaibhavUpreti]

@VaibhavUpreti could you please add spec testcases for this notifications!

Also test if the assignment got deleted, the associated notification are destroying or not! That is the edge case, we need to see!

I think has_noticed_notifications do this thing but just in case kindly test this in your end!

Yeah Sure! I will write the required specs for these... And nothing seems to be broken after deleting the assignments ... The notifications are also getting cleaned up.

[VaibhavUpreti]

@vedant-jain03 I have written the tests ... can u please check .. also I had sent u dm on slack regarding testing controller

[vedant-jain03]

@VaibhavUpreti
you need to write the test for this in #create in assignment_controller_spec.rb.

Here

Try adding under the context when primary mentor is logged in, try this:

      it "sends notifications to group members" do
        sign_in @primary_mentor
        post group_assignments_path(@group), params: { assignment:
          { description: "group assignment", name: "Test Name" } }
        expect(@member.noticed_notifications.count).to eq(1)
      end

[VaibhavUpreti]

@vedant-jain03 I think this one is good to merge now.

[vedant-jain03]

@VaibhavUpreti Great work, thanks!

cc @tachyons, we can merge this!

[VaibhavUpreti]

@vedant-jain03 , @tachyons ... Anything else needed with this patch? or are we good to merge this

[codeclimate]

An error occurred when fetching issues.

View more on Code Climate.

[VaibhavUpreti]

@tachyons @vedant-jain03 I haven't used the function "notification_type" as I think routing is part of ActionController and not present in custom classes. So the current code handles routing in the controller itself and "notify" function works for now.

Is there any way we can use "redirect_to" method in our service class ... is so then we can keep this function else remove this.

[VaibhavUpreti]

@tachyons made the controller "skinny" ... moved all the logic to the service class. Kindly review.

[vedant-jain03]

1. Why introduce a new type in service when we can already compare with schema type.
2. Stick to if-else block as we have some other notification coming up which may have a different path other than project or group.
   Else LGTM @tachyons WDYT?

[VaibhavUpreti]

@tachyons