feat: markasread in dropdown #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
tachyons
reviewed
Oct 12, 2022
|
@tachyons Removed the unwanted commits , please have a look. Thanks 👍 |
|
Unread notifications-
|
|
Fixes issue #3313 .. @tachyons @vedant-jain03 kindly review this. |
vedant-jain03
added
the
notifications
|
@tachyons @vedant-jain03 is this good for mergre? |
vedant-jain03
approved these changes
Nov 16, 2022
vedant-jain03
moved this from Ready for Review
to Approved / Ready to merge
in Main Platform Improvement
tachyons
reviewed
Nov 17, 2022
|
Code Climate has analyzed commit 72aff70 and detected 0 issues on this pull request. View more on Code Climate. |
|
@vedant-jain03 @tachyons updated "get" to "patch" ... also had to change one spec 👍 ... all tests passing |
vedant-jain03
moved this from Approved / Ready to merge
to Completed(Merged)
in Main Platform Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3313
Describe the changes you have made in this PR -
Screenshots of the changes (If any) -
BEFORE FIX
AFTER FIX
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.