fix: ActionView::Template::Error: Couldn't find User #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedant-jain03
added
the
priority
vedant-jain03
changed the title
|
cc @tachyons, kindly review |
tachyons
reviewed
Nov 3, 2022
Comment on lines
+31
to
32
| has_noticed_notifications model_name: "NoticedNotification" | ||
| has_many :noticed_notifications, as: :recipient, dependent: :destroy |
There was a problem hiding this comment.
Yes,
According to the noticed doc has_noticed_notifications should cover that edge, but I tested it for the project as well, it is giving unexpected results. So we can move ahead with the standard association method for now.
tachyons
reviewed
Nov 3, 2022
db/data_migrations/20221016052333_destroy_notifications_for_non_existing_notifier_user.rb
Outdated
Show resolved
Hide resolved
…n_existing_notifier_user.rb Co-authored-by: Aboobacker MK <aboobackervyd@gmail.com>
|
An error occurred when fetching issues. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3317
Describe the changes you have made in this PR -
data migrationnoticed_notificationassociation with user.Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.