Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Ui issue #4844

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixed Ui issue #4844

wants to merge 3 commits into from

Conversation

saltykheera
Copy link

basis CSS and UI issues fixed :
#4114
#3621
#4105

@@ -4,7 +4,8 @@
border-radius: 4px;
color: $white;
margin: 5px;
transition: all .3s ease 0s;
margin-left: 0px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0px should be written without units as 0

@@ -4,7 +4,8 @@
border-radius: 4px;
color: $white;
margin: 5px;
transition: all .3s ease 0s;
margin-left: 0px;
transition: all 0.3s ease 0s;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.3 should be written without a leading zero as .3

@@ -19,7 +20,7 @@
border-radius: 4px;
color: $white;
margin: 5px;
transition: all .3s ease 0s;
transition: all 0.3s ease 0s;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.3 should be written without a leading zero as .3

@@ -52,7 +53,7 @@
border-radius: 4px;
box-shadow: 0 2px 7px $shadow-black;
margin: 10px 15px;
transition: all .3s ease 0s;
transition: all 0.3s ease 0s;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.3 should be written without a leading zero as .3

@@ -78,9 +79,9 @@
display: inline-block;
height: 89px;
margin: 50px 7px 40px;
opacity: .89;
opacity: 0.89;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.89 should be written without a leading zero as .89

padding: 15px;
transition: box-shadow .2s ease-in;
transition: box-shadow 0.2s ease-in;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.2 should be written without a leading zero as .2

@@ -132,27 +133,27 @@

.tooltiptext {
background-color: $navbar-dark-grey;
border-radius: .3rem;
border-radius: 0.3rem;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.3 should be written without a leading zero as .3

bottom: 100%;
color: $white;
font-size: .8rem;
font-size: 0.8rem;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.8 should be written without a leading zero as .8

left: 0%;
max-width: 100%;
opacity: 0;
padding: .3rem;
padding: 0.3rem;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.3 should be written without a leading zero as .3

position: absolute;
text-align: center;
transition: opacity .5s;
transition: opacity 0.5s;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.5 should be written without a leading zero as .5

Copy link

codeclimate bot commented Mar 25, 2024

Code Climate has analyzed commit 705822f and detected 23 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 23

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant