Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (UI): Conditional Rendering of Placeholder Text Based on User Role #4938

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Darshan808
Copy link

Fixes #4937

This PR fixes an issue on the groups page where the placeholder text for no members, mentors, or assignments is the same for all user roles, including admins and students. Conditional rendering is used to display placeholder based on different user roles.

All the languages were kept in mind while changing the placeholder.

The back button is also made to look like button instead of a plain text.

Screenshots

For Admins:

Screenshot 2024-05-15 180808
Screenshot 2024-05-15 181221

For Students:

Screenshot 2024-05-15 180959
Screenshot 2024-05-15 181125

Copy link

codeclimate bot commented May 15, 2024

Code Climate has analyzed commit ae778c6 and detected 0 issues on this pull request.

View more on Code Climate.

@Darshan808
Copy link
Author

Darshan808 commented May 16, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Bug: Placeholder Text Inconsistency for Different User Roles
1 participant