Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darkmode retains after refresh #224

Merged
merged 5 commits into from
May 26, 2020

Conversation

animesh-007
Copy link
Contributor

Fixes #221

Describe the changes you have made -Added local storage feature to store the state

Screenshots of the changes (If any) -

Copy link
Member

@YashKumarVerma YashKumarVerma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
do not access localstorage values using dot

Copy link
Member

@YashKumarVerma YashKumarVerma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comment

@animesh-007
Copy link
Contributor Author

image
do not access localstorage values using dot

Ok Now I used getItem() but I m unable to keep slider ON on refresh.
Can you suggest anything?

Copy link
Member

@YashKumarVerma YashKumarVerma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dark mode retains, but the button state is not the same. check screenshot.
image

@animesh-007
Copy link
Contributor Author

The dark mode retains, but the button state is not the same. check screenshot.
image

Now it is resolved

Copy link
Member

@YashKumarVerma YashKumarVerma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do a ctrl+shift+r after opening dark mode.
error still persists.

@animesh-007
Copy link
Contributor Author

I checked on my localhost and on netlify preview too but It's working fine over there.
Screen Shot 2020-05-17 at 10 09 00 PM
The above screenshot is taken after ctrl+shift+r.
Still, I m looking to find if any problem persists.
Can you suggest anything?

docs/index.html Outdated Show resolved Hide resolved
Copy link
Member

@YashKumarVerma YashKumarVerma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@animesh-007 Can you solve the merge conflicts?

@animesh-007
Copy link
Contributor Author

@animesh-007 Can you solve the merge conflicts?

@YashKumarVerma I solved merge conflicts.

@YashKumarVerma
Copy link
Member

@ShubhankarKG @schezfaz @eKuG @coding-CEO @Shivansh2407
Can you check if this is working fine.

@schezfaz
Copy link
Contributor

Checked the following:

  • Toggle to dark mode --> Refresh page --> Dark more persists
  • Toggle to dark mode on home page --> navigate to another page (say Video demos) --> hit refresh --> Dark mode persists
  • Keep pages in light mode --> Refresh page --> Light mode persists
  • Whether toggle button state persists on refresh

All cases seem to work well, looks good to me!

@YashKumarVerma YashKumarVerma merged commit 766b887 into CircuitVerse:master May 26, 2020
@YashKumarVerma
Copy link
Member

YashKumarVerma commented May 26, 2020

Thanks a lot for your contributions @animesh-007 , @schezfaz for quick review.

@animesh-007 animesh-007 deleted the darkmode branch May 26, 2020 07:43
@ShubhankarKG ShubhankarKG mentioned this pull request May 26, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode gets switched off after refreshing the page
3 participants