Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added use of FlipFlops #7

Closed
wants to merge 3 commits into from
Closed

added use of FlipFlops #7

wants to merge 3 commits into from

Conversation

vinay72
Copy link

@vinay72 vinay72 commented Oct 19, 2018

I have documented the use of Flip Flops. #1

Copy link
Member

@satu0king satu0king left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, that is great!
However could you style the headings. Use # for tittles and ## for Sub Titles. Also rename the file as flipflops.md

Thank you

@vinay72
Copy link
Author

vinay72 commented Mar 1, 2019

@satu0king Hello, I have updated the file name to flipflops.md and also have styled the headings. Please Review my changes.

@vinay72
Copy link
Author

vinay72 commented Mar 6, 2019

@satu0king Don't consider my last commit which is on documentation of output elements. I am sorry for my inconvenience. Please review my above changes.

Copy link
Author

@vinay72 vinay72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satu0king Please review my changes.

Copy link
Member

@satu0king satu0king left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please understand that the documentation is not just for general knowledge of the circuit elements, People can refer to other resources for that. This documentation is for CircuitVerse elements and how CircuitVerse elements work.

That means an exact element in CV should be discussed - that is the various options, usage etc. Also an accompanying circuit example needs to be present.

See how the gates page is implemented.

https://docs.circuitverse.org/#/gates

Attribute Value Description
for element_id Specifies the relationship between the result of the calculation, and the elements used in the calculation
form form_id Specifies one or more forms the output element belongs to
name name Specifies a name for the output element
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Author

@vinay72 vinay72 Mar 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satu0king Okay , I understand now what you are trying to say. You can Ignore this and review my flipflops.md file.

@satu0king satu0king closed this Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants